-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ergonomics of experimental feature acknowledgement #53
Comments
We want a way to introduce new and unproven features for evaluation. We'd like to require some form of acknowledgement from the user to enable these features so that it's easy to distinguish these modules. Furthermore, this should be accomplished in a way so that users are not required to alter their configurations when the features are no longer considered experimental. Currently, modules such as the consul namer have experimental in their names, such as This should be fixed as follows:
While we're here, we should consider experimental features within a module. We have a few options in how to structure this: kind: io.l5d.consul
experimental: true kind: io.l5d.consul
experimentalSomeFeature: true Or, we could allow kind: io.l5d.consul
experimental: true kind: io.l5d.consul
experimental:
someFeature: true |
* Introduce objects to manage kubectl and shell * Make dashboard command use new shell & kubectl objects * Make compatible with version numbers like v1.9.0-beta.1 * Add version check for kubectl * Refactor error to use proper method from fmt pa ckage * Make channel and error handling more idiomatic and safe * Make version require 1.8.0
In order to use the Consul namer, you have to refer to it as
io.l5d.experimental.consul
in the namer config block, butio.l5d.consul
in the dtab. (This may also be the case for other experimental namers.)This is somewhat confusing, especially since non-experimental namers are matched in these two sections. At a minimum, this discrepancy should be documented.
The text was updated successfully, but these errors were encountered: