-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn on mismatched thriftFramed settings #27
Comments
I may be able to address this as part of my configuration work - I've been doing some thinking on how we want to handle defaults there. |
Are we happy with the current state of this now that |
If it's not a ton of work I think it still might be worthwhile to default |
I think I disagree. If there are multiple servers, which server should the client inherit from? Better would be some kind of config linter or warning if your client and server don't match. |
Fair enough, I forgot about the multiple servers case. |
I've changed the title to reflect @adleong's suggestion. |
@BoostIO funded this issue with $10. Visit this issue on Issuehunt |
Configuration values that take durations are currently specified as time values with no units. So `600` may mean 600ms in some contexts and 10 minutes in others. In order to avoid this problem, this change now requires that configurations provide explicit units for time values such as '600ms' or 10 minutes'. Fixes linkerd#27.
two issues:
thriftFramed
defaults to true at both router-level and server-level.thriftFramed
to false at the router level does not affect server-level. I'd expect the server to honor whatever is set on the router, unlessthriftFramed
is explicitly set on the server to override.The text was updated successfully, but these errors were encountered: