Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable client and server socket pools #24

Closed
olix0r opened this issue Jan 23, 2016 · 0 comments
Closed

configurable client and server socket pools #24

olix0r opened this issue Jan 23, 2016 · 0 comments

Comments

@olix0r
Copy link
Member

olix0r commented Jan 23, 2016

It's trivial to create a traffic loop:

while curl -H 'Host: woop' -H 'Dtab-local: /host/woop=>/$/inet/127.1/4140' localhost:4140 ; do :; done

馃拃 system runs out of file descriptors! 馃敨

We need to consider other means to prevent/avoid loops, but this highlights the need to be able to constrain:

  1. the number of sockets that a server may accept concurrently.
  2. the number of sockets that a single client (not router) may open.

Finagle has stack parameters to control these. We need to ensure that there are sane default values, and expose a means to configure these parameters.

@siggy siggy added the ready label Jan 25, 2016
@wmorgan wmorgan added this to the 0.0.11 milestone Feb 8, 2016
@wmorgan wmorgan assigned stevej and unassigned stevej Feb 8, 2016
@gtcampbell gtcampbell removed this from the 0.0.12 milestone Feb 22, 2016
@klingerf klingerf removed the ready label Feb 23, 2016
@adleong adleong added the ready label Mar 8, 2016
@adleong adleong self-assigned this Mar 9, 2016
@adleong adleong added in progress and removed ready labels Mar 9, 2016
Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this issue Dec 20, 2018
Previously, as soon as we would encounter one environment variable with
an invalid value we would exit. This is frustrating behavior when
deploying to Kubernetes and there are multiple problems because the
edit-compile-test cycle is so slow.

Fix this by parsing all the environment variables and logging error
messages before exiting.

I validated this manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants