Set MaxInitialLineSize from maxInitialSizeKB config #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxInitialLineSize parameter is not set from the config. This appears to be a regression in 1.7.x This commit adds test case to demonstrate the issue and a fix Fixes linkerd#2393 Signed-off-by: Dmytro Kostiuchenko <[email protected]>
There was a problem hiding this comment.
thanks @edio That makes sense. Have you verfieid that this actually fixes the problem in question?
|
@zaharidichev , yes we have tested the change on our dev environments: linkerd is able to process requests with >4KiB initial line with this change as expected. |
adleong
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaxInitialLineSize parameter is not set from the config. This appears to
be a regression in 1.7.x
This commit adds test case to demonstrate the issue and a fix
Fixes #2393
Signed-off-by: Dmytro Kostiuchenko [email protected]