Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaxInitialLineSize parameter is not set from maxInitialLineKB config value #2393

Closed
1 of 2 tasks
koiuo opened this issue May 27, 2020 · 0 comments · Fixed by #2394
Closed
1 of 2 tasks

MaxInitialLineSize parameter is not set from maxInitialLineKB config value #2393

koiuo opened this issue May 27, 2020 · 0 comments · Fixed by #2394

Comments

@koiuo
Copy link
Contributor

koiuo commented May 27, 2020

Issue Type:

  • Bug report
  • Feature request

What happened:
maxInitialLineKB config value is ignored by linkerd, resulting in 414 for request with long URLs

What you expected to happen:
maxInitialLineKB value is used to set MaxInitialLineSize parameter for the router

How to reproduce it (as minimally and precisely as possible):
set maxInitialLineKB to a 64KiB and submit a request with request line > 4KiB (default value for the maxInitialLineKB

Anything else we need to know?:
This seems to be a regression in 1.7.x

Environment:

  • linkerd/namerd version, config files: 1.7.x
koiuo added a commit to koiuo/linkerd that referenced this issue May 27, 2020
@koiuo
Set MaxInitialLineSize from maxInitialSizeKB config
0a41bef 
MaxInitialLineSize parameter is not set from the config. This appears to
be a regression in 1.7.x

This commit adds test case to demonstrate the issue and a fix

Fixes linkerd#2393

Signed-off-by: Dmytro Kostiuchenko <[email protected]>
koiuo added a commit to koiuo/linkerd that referenced this issue May 27, 2020
@koiuo
Set MaxInitialLineSize from maxInitialSizeKB config
4efc5f5 
MaxInitialLineSize parameter is not set from the config. This appears to
be a regression in 1.7.x

This commit adds test case to demonstrate the issue and a fix

Fixes linkerd#2393

Signed-off-by: Dmytro Kostiuchenko <[email protected]>
@koiuo koiuo mentioned this issue May 27, 2020
Merged
cpretzer pushed a commit that referenced this issue May 28, 2020
@koiuo
Set MaxInitialLineSize from maxInitialSizeKB config (#2394)
265499f 
MaxInitialLineSize parameter is not set from the config. This appears to
be a regression in 1.7.x

This commit adds test case to demonstrate the issue and a fix

Fixes #2393

Signed-off-by: Dmytro Kostiuchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set MaxInitialLineSize from maxInitialSizeKB config koiuo/linkerd
1 participant
@koiuo