-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
namerd: should POST set ETag? #207
Comments
in the case of zookeeper storage, the version number doesn't come back in the response from create. that means that it would require a second call to zk to get the version number. we can definitely do this, I just wanted to point out that it's not free. |
@adleong zookeeper itself gives us this for free, but we currently have some poor abstractions that hide it from us: The [ We'll likely have to move away from the finagle-serverset abstractions... |
I agree in general that we need to move away from the finagle-serverset abstractions to have the flexibility we want. In this case, |
My last comment wasn't clear. Zookeeper's |
If docker image tags were out of date, ci would not fail until the docker-deploy stage (master merge). Modify ci to validate tags as part of the default ci run. Signed-off-by: Andrew Seigner <[email protected]>
I'd expect creation to set an ETag on the repsonse?
The text was updated successfully, but these errors were encountered: