Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namerd: should POST set ETag? #207

Open
olix0r opened this issue Mar 30, 2016 · 4 comments
Open

namerd: should POST set ETag? #207

olix0r opened this issue Mar 30, 2016 · 4 comments

Comments

@olix0r
Copy link
Member

olix0r commented Mar 30, 2016

> POST /api/1/dtabs/default HTTP/1.1
> Host: 104.197.46.186
> User-Agent: curl/7.43.0
> Accept: */*
> Content-type: application/dtab
> Content-Length: 192
> 
* upload completely sent off: 192 out of 192 bytes
< HTTP/1.1 204 No Content
< Content-Length: 0
< 

I'd expect creation to set an ETag on the repsonse?

@olix0r olix0r added the ready label Mar 30, 2016
@olix0r olix0r changed the title namerd: should POST set ETag namerd: should POST set ETag? Mar 30, 2016
@adleong
Copy link
Member

adleong commented Apr 1, 2016

in the case of zookeeper storage, the version number doesn't come back in the response from create. that means that it would require a second call to zk to get the version number. we can definitely do this, I just wanted to point out that it's not free.

@olix0r
Copy link
Member Author

olix0r commented Apr 3, 2016

@adleong zookeeper itself gives us this for free, but we currently have some poor abstractions that hide it from us: The [setData api](https://zookeeper.apache.org/doc/r3.4.6/api/org/apache/zookeeper/ZooKeeper.html#setData%28java.lang.String, byte[], int%29) returns a Stat that contains the node's version.

We'll likely have to move away from the finagle-serverset abstractions...

@adleong
Copy link
Member

adleong commented Apr 4, 2016

I agree in general that we need to move away from the finagle-serverset abstractions to have the flexibility we want. In this case, setData returns a Stat but create does not.

@adleong
Copy link
Member

adleong commented Apr 5, 2016

My last comment wasn't clear. Zookeeper's create method does not return a Stat so I don't think moving off of finagle-serversets helps in this particular case.

@adleong adleong mentioned this issue Apr 6, 2016
Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this issue Dec 20, 2018
If docker image tags were out of date, ci would not fail until the
docker-deploy stage (master merge).

Modify ci to validate tags as part of the default ci run.

Signed-off-by: Andrew Seigner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants