Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS: PEM-encoded certificate bundles that do not end in a newline aren't working #1772

Open
1 task done
briansmith opened this issue Jan 9, 2018 · 0 comments
Open
1 task done

TLS: PEM-encoded certificate bundles that do not end in a newline aren't working #1772

briansmith opened this issue Jan 9, 2018 · 0 comments

Comments

@briansmith
Copy link

Issue Type:

  • Bug report

See https://discourse.linkerd.io/t/trust-client-certificate-without-newline-at-the-end-is-causing-openssl-problem/488. According to https://tools.ietf.org/html/rfc7468#section-3 whitespace at the end is optional so this does seem like a bug in linkerd. It is easy to work around: Just append a newline to the file. It would be nice if the workaround weren't necessary.
Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this issue Dec 20, 2018
@alpeb
Add Grafana dashboard for Authorities (linkerd#1772)
338848d 
* Add Grafana dashboard for Authorities

Proposal for linkerd#1225

Signed-off-by: Alejandro Pedraza <[email protected]>

* Implement code review suggestions

Modified Inbound by Deployment and Inbound by Pod graphs according to klingerf's feedback.
Removed template variables values.

Signed-off-by: Alejandro Pedraza <[email protected]>
Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this issue Dec 20, 2018
Dashboard Table cleanups (linkerd#1793)
98ee363 
This branch includes some small appearance tweaks for tables in the app.

- Removes the restrictions on the MetricsTables for Authorities Grafana 
links (Authorities Grafana dashboards were added in linkerd#1772)
- Fixes the tables overflowing their containers on the Overview page
- Allows tables to be denser, allowing for more data on screen
- Fixes the colour of the meshed status bar in the ServiceMesh page
- Rixes the ErrorModal icon alignment and colour
- Small appearance tweaks to the things in the table e.g. icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@briansmith