-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for large requests and responses #1691
Comments
koiuo
added a commit
to koiuo/linkerd
that referenced
this issue
Oct 22, 2018
PoC fix for linkerd#1691
koiuo
added a commit
to koiuo/linkerd
that referenced
this issue
Oct 22, 2018
Requires custom finagle 18.5.0 twitter/finagle#740 PoC fix for linkerd#1691
It seems, that once the feature is implemented in finagle, linkerd should have support for it almost automatically. I made a PoC patch for finagle twitter/finagle#740 As a result I was able to route 1000 MiB unchunked request using only 64 MiB heap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Linkerd is currently reading whole requests and responses into memory which can can be problematic when those are large. Chunked encoding helps with this but is not an option in some cases.
I'm not an expert in Finagle / Netty but looks like Netty has all the capabilities needed and the lack of support for streaming large requests and responses should be added on Finagle level so it also becomes a feature of linkerd. This particular issue looks relevant: twitter/finagle#538
In any case, regardless of the underlying technicalities, as customers with a requirement for supporting larger requests and responses, we'd be interested to see this feature materialize in linkerd soon.
The text was updated successfully, but these errors were encountered: