-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add h2 gRPC Identifier #1687
Comments
Thanks for filing this, @matt-turner-skyscanner! |
Tim-Brooks
pushed a commit
to Tim-Brooks/linkerd
that referenced
this issue
Dec 20, 2018
Closes linkerd#1683 Signed-off-by: Mathis Wiehl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Type:
Part IX of the k8s service mesh blog gives a good into to routing gRPC through l5d, but in a lot of ways it feels a bit 2nd class. One of our big issues is the need to use domainToPathPfx to extract the service name from the h2 path (supposing that format will never change), and even then that ignores the package so services have to be globally unique across k8s namespaces (we used a custom re-writer to work round that). It would be great to have a first-class gRPC identifier which pulled the service name (and perhaps the last section of the package name) from the packet (which happens to be an h2 header frame).
The text was updated successfully, but these errors were encountered: