Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add h2 gRPC Identifier #1687

Open
1 of 2 tasks
matt-turner-skyscanner opened this issue Oct 27, 2017 · 1 comment
Open
1 of 2 tasks

Add h2 gRPC Identifier #1687

matt-turner-skyscanner opened this issue Oct 27, 2017 · 1 comment

Comments

@matt-turner-skyscanner
Copy link

Issue Type:

  • Bug report
  • Feature request

Part IX of the k8s service mesh blog gives a good into to routing gRPC through l5d, but in a lot of ways it feels a bit 2nd class. One of our big issues is the need to use domainToPathPfx to extract the service name from the h2 path (supposing that format will never change), and even then that ignores the package so services have to be globally unique across k8s namespaces (we used a custom re-writer to work round that). It would be great to have a first-class gRPC identifier which pulled the service name (and perhaps the last section of the package name) from the packet (which happens to be an h2 header frame).

@wmorgan
Copy link
Member

wmorgan commented Oct 27, 2017

Thanks for filing this, @matt-turner-skyscanner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants