Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support admin configuration #16

Closed
siggy opened this issue Jan 20, 2016 · 0 comments
Closed

support admin configuration #16

siggy opened this issue Jan 20, 2016 · 0 comments
Milestone

Comments

@siggy
Copy link
Member

siggy commented Jan 20, 2016

The admin server should be configurable via linkerd's configuration file. I.e something like:

admin:
  port: 9991
  ip: any
  superCoolExperimentalAdminFeature: true

routers:
- ...

The admin server should be initialized with a Linker's config state (including)

This probably necessitates moving away from TwitterServer's provided admin service and instantiating our own (reusing as much as possible from TwitterServer).

An admin field be added to the Linker trait, probably accompanied by a withAdmin helper. The admin configuration should be parsed after all routers have been parsed so that it may be configured against the routers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants