Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support connection-level flow control configuration #1044

Open
olix0r opened this issue Feb 3, 2017 · 0 comments
Open

Support connection-level flow control configuration #1044

olix0r opened this issue Feb 3, 2017 · 0 comments
Labels
h2

Comments

@olix0r
Copy link
Member

olix0r commented Feb 3, 2017 •
edited
Loading

Currently, Netty's DefaultHttp2LocalFlowController provides no mechanism to configure the initial window size of the connection stream. Setting initial window size on the flow controller does nothing to change the connection stream's flow control window. This means that a connection window of 65535 is enforced when AutoRefillConnectionWindow is configured to false.
@olix0r olix0r added the h2 label Feb 3, 2017
@olix0r olix0r self-assigned this Feb 3, 2017
olix0r added a commit that referenced this issue Feb 3, 2017
@olix0r
[h2] Refine HTTP/2 configuration
591112c 
Some aspects of HTTP/2 router configuration don't really add up:
- Only stream window sizes are currently configurable (until #1044), so rename
  `initialWindowSize` to `initialStreamWindowSize`.
- In light of this, it doesn't make sense to expose `connectionFlowControl`
  as configuration.
- Furthermore, it doesn't make sense to enable connection-level flow control
  until it can be configured. Default AutoRefillConnectionWindow to true.
- It doesn't make sense to expose `maxConcurrentStreamsPerConnection` on
  clients, since we disable support for PUSH messages.
@olix0r olix0r mentioned this issue Feb 3, 2017
Closed
olix0r added a commit that referenced this issue Feb 4, 2017
@olix0r
[h2] Refine HTTP/2 configuration (#1045)
c1262ce 
Some aspects of HTTP/2 router configuration don't really add up:
- Only stream window sizes are currently configurable (until #1044), so rename
  `initialWindowSize` to `initialStreamWindowSize`.
- In light of this, it doesn't make sense to expose `connectionFlowControl` as
  configuration.
- Furthermore, it doesn't make sense to enable connection-level flow control
  until it can be configured. Default AutoRefillConnectionWindow to true.
- It doesn't make sense to expose `maxConcurrentStreamsPerConnection` on
  clients, since we disable support for PUSH messages.
- Http2Settings should be configured against the decoder and flow controller
Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this issue Dec 20, 2018
@klingerf
Update controller to use 'tls' metric label (linkerd#1044)
ec2433e 
* Update controller to use 'tls' metric label
* Fix meshed column formatter

Signed-off-by: Kevin Lingerfelt <[email protected]>
@adleong adleong mentioned this issue Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
h2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olix0r