review system design module #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - https://learning.oreilly.com/library/view/the-art-of/9780134031408/ch23.html | ||
|
|
||
| ## Scalability - Sharding | ||
|
|
||
| This pattern represents the separation of work based on attributes that are looked up or determined at the time of the transaction. Most often, these are implemented as splits by requestor, customer, or client. | ||
| This pattern represents the separation of work based on attributes that are looked up to or determined at the time of the transaction. Most often, these are implemented as splits by requestor, customer, or client. |
There was a problem hiding this comment.
Original was correct here, looked up "to" is redundant here
There was a problem hiding this comment.
grammarly says it's ok
sanketplus
force-pushed
the
system-design
branch
from
37ba3e8
to
c2a1ee3
Compare
kalyanceg
pushed a commit
that referenced
this pull request
Dec 7, 2020
Thanks Sanket and Sumesh for the review Merging them
kalyanceg
added a commit
that referenced
this pull request
Dec 7, 2020
* initial commit for linux basics module * Add backlinks to linux course * Add backlinks to linux course * call for contributors * call for contributors * call for contributors and add to root * fix typo inmkdocs * broken image path in linux basics * broken image path in linux basics * broken image path in linux basics * split conclusion in networking * add conclusion page, modify subtitles and links * add conclusion page, modify subtitles and links * minor suggestions incorporation into git course * Initial draft of NoSQL DB * Updated Links & adding images * Fixing Image Links * Added conclusion * Update conclusion.md Fixed typo * Wrapping lines to beautify * Merging some pages and modifying suggestions in Big Data module * Fix mistakes in mkdocs yaml and add Nosql to nav * github flavored image width * github flavored image width * overrides for custom mkdocs partials * Revert "github flavored image width" This reverts commit 70e704d. * overrides for custom mkdocs partials * github flavored image width * Fixing links and standardising titles * Enable search * nosql module review * change images size * Linux module review * Review and corrections in the Security module * Fixed typos errors in intro & big_data * Fixed typo in image * Add local build documentation * Add python dependencies file * Fix NoSQL course title * Add Linux Basics title to intro page * Add custom stylesheet for content image border * Internal review of git course * Add Relational Databases course (#21) Looks good to me * Fix dangling links in mysql, add TOC in mysql, incorporate network review * review system design module (#31) Thanks Sanket and Sumesh for the review Merging them * Nosql standardising format * Update repository url in contribute * Rewording intro after internal review * review language to be inclusive (#33) * review language to be inclusive * review language to be inclusive * fix typo for Example Co-authored-by: Kalyanasundaram Somasundaram <[email protected]> * improved font size in systems design images * Uploading License and Notice contents * Merge fix after rebase Co-authored-by: Shivam Mitra <[email protected]> Co-authored-by: Kalyanasundaram Somasundaram <[email protected]> Co-authored-by: Sanket Patel <[email protected]> Co-authored-by: Sai Kiran Kanuri <[email protected]> Co-authored-by: Sai Kiran Kanuri <[email protected]> Co-authored-by: Nishant Singh <[email protected]> Co-authored-by: Nishant Singh <[email protected]> Co-authored-by: Aditya Kamat <[email protected]> Co-authored-by: Sumesh Premraj <[email protected]> Co-authored-by: Sumesh Premraj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kalyanceg apologies for
centre -> center🙈