Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcr-2.0] Remove unused code and blob-layouts #2852

Merged
merged 5 commits into from
Aug 5, 2024
Merged

[vcr-2.0] Remove unused code and blob-layouts #2852

merged 5 commits into from
Aug 5, 2024

Conversation

snalli
Copy link
Contributor

@snalli snalli commented Aug 2, 2024

Removing some legacy code that could be problematic if misconfigured.

Removing some legacy code that could be problematic
if misconfigured.
@snalli snalli changed the title [vcr-2.0] Remove unused blob-layouts [vcr-2.0] Remove unused code and blob-layouts Aug 2, 2024
Copy link
Collaborator

@justinlin-linkedin justinlin-linkedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snalli
Copy link
Contributor Author

snalli commented Aug 2, 2024

LGTM

Thanks, I just removed the unused configs completely, on second thought. If that looks good to you, i'll merge. @justinlin-linkedin

@snalli snalli merged commit 1f37df7 into master Aug 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants