Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional configuration paths #651

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Add support for additional configuration paths #651

merged 3 commits into from
Nov 22, 2023

Conversation

lujjjh
Copy link
Collaborator

@lujjjh lujjjh commented Nov 22, 2023

The configuration file will be located in the order below:

  1. ~/Library/Application Support/linearmouse/linearmouse.json
  2. ~/.config/linearmouse/linearmouse.json

This commit enables the use of additional configuration locations, including the standard ~/Library/Application Support path, to provide users with more flexibility.

The configuration file can now be located as follows:

  1. ~/Library/Application Support/linearmouse/linearmouse.json
  2. ~/.config/linearmouse/linearmouse.json (The original location)

To maintain backward compatibility and prevent any disruptions, new configurations will still be created in location 2.

Closes #644.

The configuration file will be located in the order below:

1. ~/Library/Application Support/linearmouse/linearmouse.json
2. ~/.config/linearmouse/linearmouse.json

This commit enables the use of additional configuration locations,
including the standard ~/Library/Application Support path, to
provide users with more flexibility.

The configuration file can now be located as follows:

1. ~/Library/Application Support/linearmouse/linearmouse.json
2. ~/.config/linearmouse/linearmouse.json (The original location)

To maintain backward compatibility and prevent any disruptions,
new configurations will still be created in location 2.

Closes #644.
@lujjjh lujjjh merged commit dde7556 into main Nov 22, 2023
2 checks passed
@lujjjh lujjjh deleted the config-path branch November 22, 2023 15:16
@lujjjh lujjjh added the enhancement New feature or request label Dec 3, 2023
@ultratiem
Copy link

Apple guidelines dictate that any config files or files in general needed by an app install to ~/Library/Application Support. That is the standard and ubiquitous location for all application files on macOS.

macOS does not use hidden directories nor should it. Nor does it install to a users home folder. That is a Linux standard.

This commit leads to user confusion as now there are 2 config files. Moreover, the secondary location is not ideal as macOS users should have to look for hidden directories.

This commit should leave the correct location (~/Library/Application Support), and remove the .config folder entirely. There is almost no gain for a user to move config files or store them in another location. All this will do is add a layer of confusion and takes the app further away from one designed exclusively for macOS.

with respect.

@lujjjh
Copy link
Collaborator Author

lujjjh commented Dec 7, 2023

Hi @ultratiem! Thanks for your feedback.

To clarify, this pull request marks the beginning of the migration of the configuration from ~/.config to ~/Library/Application Support. However, to avoid introducing breaking changes before the next major update, it is necessary to keep the original configuration path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I want to locate configuration file to ~/Library/Application Support
2 participants