Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs/fix tpm parser #31

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Bugs/fix tpm parser #31

merged 3 commits into from
Sep 16, 2022

Conversation

kj84park
Copy link
Member

@kj84park kj84park commented Sep 8, 2022 •
edited
Loading

What is this PR for?

Resolved #27

Tasks

  • TPM Public area for ECC key algorithm parsing issue has been fixed, and related code has been refactored.

References

@kj84park kj84park added the defect Something isn't working label Sep 8, 2022
haxelion
haxelion reviewed Sep 15, 2022
View reviewed changes
Copy link

@haxelion haxelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really convinced by the robustness of the signature verification code.
However that would be much more work to fix it.

server/src/main/java/com/linecorp/line/auth/fido/fido2/server/attestation/tpm/TpmParser.java Show resolved Hide resolved
@haxelion haxelion self-requested a review September 15, 2022 06:13
haxelion
haxelion approved these changes Sep 15, 2022
View reviewed changes
Copy link

@haxelion haxelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this fix the issue but the TPM code would probably benefit from more attention in general. Unfortunately I don't have the time to look at it right now.

@kj84park kj84park merged commit a22f388 into line:main Sep 16, 2022
@kj84park kj84park deleted the bugs/fix_tpm_parser branch September 16, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haxelion haxelion haxelion approved these changes

@aseigler aseigler aseigler approved these changes

Assignees
No one assigned
Labels
defect Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TPM attestation parser does not correctly handle ECC keys in pubArea
3 participants
@kj84park @haxelion @aseigler