Add Docker configuration files #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ric-sapasap
reviewed
Nov 18, 2021
docker-compose.yml
Outdated
Comment on lines
3
to
14
| rp: | ||
| container_name: rp-server | ||
| image: kj84park/rp-server:0.0.1 | ||
| ports: | ||
| - "8080:8080" | ||
| restart: always | ||
| fido2: | ||
| container_name: fido2-server | ||
| image: kj84park/fido2-server:0.0.1 | ||
| ports: | ||
| - "8081:8081" | ||
| restart: always |
There was a problem hiding this comment.
In my opinion, it would be better if the images are built from the local Dockerfiles, instead of pulled from dockerhub.
There was a problem hiding this comment.
For the Dockerfiles themselves, we can use multi-stage docker builds so the build process is isolated from the local environment
There was a problem hiding this comment.
Thank you so much for the suggestion! 👍
Let me check.
There was a problem hiding this comment.
@ric-sapasap
I have changed the settings according to your comments. thank you.
If you have any more comments, please.
There was a problem hiding this comment.
Looks amazing. Thank you very much @kj84park!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Overview or reasons
Tasks