Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RequestContextExtension.hook() public API #5107
Make RequestContextExtension.hook() public API #5107
Changes from all commits
ebab297
e4e4e3f
d2dfd8e
f533660
f11412b
15af7cb
013cedc
2af76dd
9cdd0db
e9601ba
197d87f
012603f
cbea40d
741ac4e
04be7e7
2a9c7b3
df37ad7
47bb671
677b29c
c106725
fc68513
f9b0848
da3e278
16e7955
cc4e315
716395a
913734f
00f0a4a
9098daa
ecf5921
2738552
92ff118
687bd8b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 163 in core/src/main/java/com/linecorp/armeria/client/ClientRequestContextWrapper.java
Codecov / codecov/patch
core/src/main/java/com/linecorp/armeria/client/ClientRequestContextWrapper.java#L162-L163
Check warning on line 167 in core/src/main/java/com/linecorp/armeria/client/ClientRequestContextWrapper.java
Codecov / codecov/patch
core/src/main/java/com/linecorp/armeria/client/ClientRequestContextWrapper.java#L167
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to override the rest of the methods
e.g.
Check warning on line 276 in core/src/main/java/com/linecorp/armeria/internal/common/NonWrappingRequestContext.java
Codecov / codecov/patch
core/src/main/java/com/linecorp/armeria/internal/common/NonWrappingRequestContext.java#L276