Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reference to args4c for command-line-to-config utils #625

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Added reference to args4c for command-line-to-config utils #625

merged 1 commit into from
Apr 18, 2019

Conversation

aaronp
Copy link
Contributor

@aaronp aaronp commented Mar 19, 2019

It seemed there wasn't a library to bridge the gap between the main entry point and running an app based on a Config.

I've added a link to consider 'args4c', which exposes some utilities for converting command-line arguments into a lightbend config

@lightbend-cla-validator
Copy link
Collaborator

Hi @aaronp,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http:https://www.lightbend.com/contribute/cla

@aaronp
Copy link
Contributor Author

aaronp commented Mar 19, 2019

Thanks! I've signed the CLAs, though it seems my PR to the readme.md broke a test ;-)

looks like checkstyle wasn't happy trying to find http:https://www.puppycrawl.com/dtds/configuration_1_3.dtd

@andreaTP
Copy link
Contributor

@aaronp
Copy link
Contributor Author

aaronp commented Mar 21, 2019 via email

Copy link
Contributor

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2m 2m merged commit f401834 into lightbend:master Apr 18, 2019
@2m 2m added this to the 1.3.4 milestone Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants