Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never pass null ConfigOrigin to PathParser.parsePathNodeExpression #538

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Never pass null ConfigOrigin to PathParser.parsePathNodeExpression #538

merged 1 commit into from
Feb 21, 2018

Conversation

javaerb
Copy link
Contributor

@javaerb javaerb commented Jan 11, 2018

This was causing NPEs on certain parse errors while trying to construct a ConfigException

@javaerb
Never pass null ConfigOrigin to PathParser.parsePathNodeExpression
ce45141 
This was causing NPEs on certain parse errors while trying to construct a ConfigException
@javaerb
Copy link
Contributor Author

javaerb commented Jan 13, 2018

CLA signed

@havocp
Copy link
Collaborator

havocp commented Jan 16, 2018

Thanks, makes sense! Should plan to merge this before the next release. Tests would not be bad, here (potentially to verify the right error is thrown with the right line number in it), if anyone wants to take a crack at that.

@havocp havocp mentioned this pull request Feb 21, 2018
Merged
@javaerb
Copy link
Contributor Author

javaerb commented Feb 21, 2018

Thanks, and sorry, I would have loved to add a test, but my time is currently a bit limited, and I am not yet familiar with the build system.

@ktoso
Copy link
Contributor

ktoso commented Feb 21, 2018

Thanks for the contrib regardless!

@ktoso ktoso merged commit d225355 into lightbend:master Feb 21, 2018
@ktoso ktoso added this to the 1.3.3 milestone Feb 21, 2018
aalleexxeeii pushed a commit to aalleexxeeii/typesafe-config that referenced this pull request Jun 6, 2018
@javaerb @ktoso
Never pass null ConfigOrigin to PathParser.parsePathNodeExpression (l…
17e0f65 
…ightbend#538)

This was causing NPEs on certain parse errors while trying to construct a ConfigException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
candidate for next release
Projects
None yet
Milestone
1.3.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@javaerb @havocp @ktoso