Display "view" button if challenge has rules #15600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would prefer to default it to an empty array, but seems like this is an okay compromise. I do not want to change this on the API level (?).
we only care about the presence of rules, not the rules themselves, so let's not hardcode them here
since only one of the two will actually be used
|
Nice, but the view button should look more clickable. Maybe |
What do you think about this? My ":hover fanciness" is quite lacking, so I just resorted on bumping the font-size 😅. CleanShot.2024-06-25.at.21.05.29.mp4 |
bastianpedersen
deleted the
if-challenge-has-rules-dont-accept-immediately
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15582.
One thing I am not sure about is the styling of the button. At the moment it only has a pointer cursor if hovered. We probably need to add some styling to this.
CleanShot.2024-06-25.at.10.36.28.mp4