remove breakpoint syntax and library #14893
Conversation
| $medium: 980px; | ||
| $large: 1120px; | ||
| $x-large: 1260px; | ||
| $xx-large: 1360px; |
There was a problem hiding this comment.
This value changed from 1500px to 1360px. Why? Are there any other functional changes in this PR?
There was a problem hiding this comment.
I think it was 1360px when this branch's code was actually forked and maybe became 1500px at some point recently?
There was a problem hiding this comment.
There are no intentional changes to any function, that was due to the block in question having a heritage in topnav-tweaks/_variables.scss which didn't pick up the corresponding mq-xx-large change in _media-queries.scss
ui/common/css/header/_title.scss
Outdated
| display: block; | ||
| } | ||
|
|
||
| @include breakpoint($mq-topnav-hidden) { | ||
| @media (max-width: at-most($medium)) { |
There was a problem hiding this comment.
we are losing some meaning here, before it was clear that it was about the topnav being visible or not. But after the change it looks arbitrary, like it could be changed - but it could not.
In this this precise case I suppose we could use a mixin like the mq-subnav-top one; but a bit later...
I think the basic scss syntax is clearer, and removing the library shaves 1-2 seconds off of sass build times.
from 7s down to 5.1