Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scottish, Whales, English Flags #1286

Closed
KirbysFoot opened this issue Dec 6, 2015 · 3 comments
Closed

Scottish, Whales, English Flags #1286

KirbysFoot opened this issue Dec 6, 2015 · 3 comments
Assignees
Labels
good first issue Narrow in scope (but not necessarily easy)

Comments

@KirbysFoot
Copy link

A user has requested that these flags be added:

_england - The English flag
_scotland - The Scottish flag
_wales - The Wales flag

All are 16x16, shiny and in PGN format.

@ornicar
Copy link
Collaborator

ornicar commented Dec 7, 2015

what are these countries ISO codes? https://github.com/ornicar/lila/blob/master/modules/user/src/main/Countries.scala

Closed until someone answers.

@ornicar ornicar closed this as completed Dec 7, 2015
@ghost
Copy link

ghost commented Dec 7, 2015

They don't, but they are part of the United Kingdom (ISO code: GB). You could just cheese it and call England 'EN' or something, or you could try to 'rationalise' it a bit and go with something like GB-EN. But yeah, they're not represented in the standard.

@thomas-daniels
Copy link
Member

@ornicar I might be late, but here they are: https://en.wikipedia.org/wiki/ISO_3166-2:GB

England: GB-ENG
North Ireland: GB-NIR
Scotland: GB-SCT
Wales: GB-WLS

@Unihedro Unihedro reopened this Jan 20, 2016
@Unihedro Unihedro added the good first issue Narrow in scope (but not necessarily easy) label Jan 20, 2016
@Unihedro Unihedro self-assigned this Feb 25, 2016
ornicar added a commit that referenced this issue Feb 26, 2016
Added several country and SAR flags - closes #1286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Narrow in scope (but not necessarily easy)
Projects
None yet
Development

No branches or pull requests

4 participants