-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page and board shift with lots of spectators #1251
Comments
5 lines is not enough for when you're sizing your browser like that (where it can only display four lines). Unfortunately, the conventional browser implementation of the window width excludes space consumed for scroll bars, so some websites simply make the scrollbar as thin as two pixels to avoid the trouble caused by content overflow. Although, it's probably the best to do (limiting spectator box maximum height). |
I was thinking you could surround the spectators list with a spectator box (fixed dimensions, roughly 5 lines high) like the one used for the chat window. So if I size my browser to fit 4 lines of spectators (like in the gif) and I only have 4 lines of spectators the page will still overflow due to the bottom border of the spectator box. Playing with a short window that requires a scrollbar is fine as long as it doesn't change mid-game. |
aha. |
This CSS seems to accomplish what I was thinking: https://userstyles.org/styles/121112/trap-spectators-in-a-box Where it is now, you have to show an empty spectator box even when there are no spectators just to be absolutely certain that the page height never changes during a game. However, if you move the spectators or shrink the chat so the sudden appearance of a 5 line high box can never add to the height of the page then you wouldn't need to force the empty box to be visible. |
As an idea or a candidate solution, |
I experimented with something similar that only affects the game and Lichess TV pages: https://userstyles.org/styles/120935/hide-scrollbar-during-games-on-lichess-org It's not ideal though; sometimes I want to scroll down to read the head to head records or other things below the game board. It would solve the problem, but it might be better if the page height never changed during a game. |
Personally I'd prefer if the menu bar (top) and the left panels were separate frames from the lower-right "quadrant" (all content other than the menu bar and left panels). But I tend to prefer functionality over elegance! :-) |
* master: (21 commits) fix mongo deprecation warnings fix mongodb aggregation framework imports update play-reactivemongo send deploy notifications to slack dark theme tweak chat public notice - closes #1383 change the chat input placeholder to "Be nice in the chat!" - for #1383 improve timeline game end entries fix height for spectators box - closes #1251 fixes #1343 round: notify takeback, draw offer, and rematch - closes #1354 analysis menu on dark theme add bookmarked flag to the game API - closes #1355 report form help - closes #1381 de "Deutsch" translation #15533. Author: toast. hr "hrvatski" translation #15532. Author: LJM7. mg "fiteny malagasy" translation #15531. Author: Ranto. implement tournament performance rating refresh tor nodes more often fetch player pairings out of sheet calculation ...
My apologies if you are all already on this, but I've noticed at least 3 forum posts confused about what I believe is the same issue over the last few weeks (1, 2, 3).
Issue: When a large number of spectators suddenly join a game, the extra text can overflow the height of the browser window causing a scrollbar to appear on the right and shift the board a few pixels to the left. When they leave (for example they are no longer on Lichess TV), it shifts back. This can happen frequently in one game if the text is just barely overflowing the page, see below.
Possible solution: The spectator box could have fixed dimensions (say 5 lines?) so when there are lots of spectators it has its own scrollbar just like the move list. It never changes the height of the screen because it is always 5 lines high whether there are 0 spectators or 200.
The text was updated successfully, but these errors were encountered: