xusb minor fixes: Restore LIBUSB_DEBUG check, check for vid:pid #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider different scenario to return from main, we have to choose the proper return value. In this way, we can easily check the return code directly like `echo $?` in Linux to know whether the execution of xusb is failed. Signed-off-by: Yiwei Lin <[email protected]>
a) xusb should set log level to INFO unless run with -d or if LIBUSB_DEBUG has been set by the user. b) It also used to set LIBUSB_DEBUG itself in order to get log output already during libusb_init. When we in commit 0929a2b replaced (b) with use of libusb_init_context() the probe for LIBUSB_DEBUG (a) was inadvertently removed. Restore this. Also remove some unused remains of previous LIBUSB_DEBUG resetting. Signed-off-by: Tormod Volden <[email protected]>
And adjust variable scope. No behaviorial changes. Signed-off-by: Tormod Volden <[email protected]>
Also combine the argument count check now that we do it up front, resulting in one indentation level less. Fixes libusb#1438 Signed-off-by: Tormod Volden <[email protected]>
Make testlibusb output align better, like lsusb does it. Signed-off-by: Tormod Volden <[email protected]>
tormodvolden
force-pushed
the
xusb_minorfixes
branch
from
a296571
to
a6a029c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.