Reintroduce RAW_IO support in WinUSB backend #1512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesFranke-smartoptics
force-pushed
the
raw_io_v2
branch
2 times, most recently
from
ca53de1
to
cb0a7ad
Compare
RAW_IO was originally added in commit 9e4bb9c via set_option(), then removed in dac541d. This commit is based on code written by martinling in PR libusb#1297. It reintroduces RAW_IO by using three new functions: - libusb_endpoint_supports_raw_io() - libusb_endpoint_set_raw_io() - libusb_get_max_raw_io_transfer_size() This follows lengthy discussions in PR libusb#1208 and libusb#1297 on how to implement RAW_IO in a generic way. Ultimately martinling chose the approach of using multiple new API functions in comment libusb#1208 (comment) > On further reflection, I am much less keen on the constraint API > idea if there is no other use case for it. So far nobody here > has come up with one, and I haven't either.
HannesFranke-smartoptics
force-pushed
the
raw_io_v2
branch
from
cb0a7ad
to
3a62095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of PR #1297 which also supports composite devices, using the same mechanism as other functions which support composite devices, e.g.
libusb_submit_transfer().It provides RAW_IO support by introducing three new API functions: