Fix warnings when building without logging and assertions #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1fda075
to
8180e0f
Compare
seanm
reviewed
Jun 11, 2024
8180e0f
to
5ae0af3
Compare
seanm
approved these changes
Jun 11, 2024
|
Great. These warnings appeared on our CI under "disable-log" e.g. https://github.com/libusb/libusb/actions/runs/9276043837/job/25522153726 but went unnoticed or were ignored so far. It is tempting to add -Werror on some builds. But there is still one of these warnings on the CI run for this PR: https://github.com/libusb/libusb/actions/runs/9466763707/job/26086717421?pr=1508 |
|
@oleavr Would you be interested in fixing the last remaining warning as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.