platform/miyoo: Enable NEAREST audio resampler #13694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This platform actually defaults to the NEAREST audio resampler.
|
Good catch! LGTM |
jdgleaver
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable the NEAREST audio resampler, which may have been inadvertently commented out in the initial port in #12860 as this platform actually defaults to the NEAREST audio resampler. Currently once you change away from the default audio resampler you cannot select "nearest" again as it's not built.
Related Issues
None
Related Pull Requests
None
Reviewers
Perhaps @jdgleaver and @salvacam from the initial port