Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinction between Mifare4K and Mifare Plus 4K #101

Open
xaqq opened this issue Dec 8, 2015 · 0 comments
Open

Distinction between Mifare4K and Mifare Plus 4K #101

xaqq opened this issue Dec 8, 2015 · 0 comments
Labels
code enhancement

Comments

@xaqq
Copy link
Contributor

xaqq commented Dec 8, 2015

MifarePlus detection is based mostly on hard-coded ATR. It turns out that one of these ATR (3B8F8001804F0CA0000003060300020000000069) conflict with the ATR for Mifare4K card.

We disable the mapping between 3B8F8001804F0CA0000003060300020000000069 and MifarePlus.
The corresponding code is in atrparser.cpp.

Reader used for test: OK5321.
xaqq added a commit that referenced this issue Dec 8, 2015
@xaqq
Disable one hardcoded ATR that maps to Mifare Plus.
f60f831 
See #101.
Also fixes Mifare4K instanciation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xaqq @Maxhy