submodule: reimplement with Python CFFI. #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The submodule type has been implemented as a C type. When opening a submodule's repository this leads to the bug that instead of an actual pygit2.Repository being instantiated we only create an object of the C Repository type. As this is not trivially fixed within the C code, reimplement the submodule type as a Python interface with CFFI. As submodules provide no functionality that is usually accessed repeatedly the code paths should not prove performance critical. In addition, maintainability is improved by this reimplementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The submodule type has been implemented as a C type. When opening
a submodule's repository this leads to the bug that instead of an
actual pygit2.Repository being instantiated we only create an
object of the C Repository type.
As this is not trivially fixed within the C code, reimplement the
submodule type as a Python interface with CFFI. As submodules
provide no functionality that is usually accessed repeatedly the
code paths should not prove performance critical. In addition,
maintainability is improved by this reimplementation.
This PR is equivalent to the first commit of PR #513 with fixes for Python 3 compatibility. I'll create another PR for write support as soon as libgit2/libgit2#2999 is merged, which also fixes the issue that occured for the two other commtis.