Fix garbled mirror configuration in recipe for git clone --mirror
#1072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation contains a recipe for how to emulate
git clone --mirror
. Inthe example code, the init_remote callback constructs the mirror configuration
passing
name
to str.format. However, the callback receives thename
(andurl
) as bytes, so str.format would return something like this:This commit fixes the code example by decoding
name
when used with str.format.The invocation of
repo.remotes.create
in the same example works fine as is,because that function invokes
to_bytes
on its arguments, andto_bytes
is anoop when passed bytes.