Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add travis step to check whitespace #259

Merged
merged 4 commits into from
Aug 30, 2021
Merged

Add travis step to check whitespace #259

merged 4 commits into from
Aug 30, 2021

Conversation

ccope
Copy link
Contributor

@ccope ccope commented Aug 27, 2021 •
edited
Loading

  • Add the code checks, get red build
  • Apply fixes, get green build
  • Commit .git-blame-ignore-revs file after review

@ccope ccope force-pushed the formatter branch 2 times, most recently from ee2e1de to 6ed05c8 Compare August 28, 2021 07:18
@ccope ccope marked this pull request as ready for review August 28, 2021 07:39
@ccope
Copy link
Contributor Author

ccope commented Aug 28, 2021

Example of a failing build: https://app.travis-ci.com/github/libfuse/sshfs/builds/236422045

@ccope
Copy link
Contributor Author

ccope commented Aug 28, 2021 •
edited
Loading

This supersedes the whitespace fixes in #257 but the editorconfig would still be useful.

@ccope ccope mentioned this pull request Aug 28, 2021
Closed
@Nikratio
Copy link
Contributor

Looks good, thank you!

@Nikratio Nikratio merged commit d54c7ec into libfuse:master Aug 30, 2021
@Nikratio
Copy link
Contributor

Could you make the .git-blame-ignore-revs as well, now that this is merged?

@ccope ccope deleted the formatter branch August 30, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ccope @Nikratio