Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppVeyor CI for Cygwin #138

Merged
merged 1 commit into from
Aug 11, 2018
Merged

Add AppVeyor CI for Cygwin #138

merged 1 commit into from
Aug 11, 2018

Conversation

billziss-gh
Copy link
Collaborator

@billziss-gh billziss-gh commented Aug 1, 2018

This PR adds AppVeyor CI support to SSHFS.

The included scripts build SSHFS against both Cygwin 64-bit and Cygwin 32-bit. This should ensure that Cygwin remains a valid target for SSHFS going forward.

To use this you will need a free AppVeyor account.

EDIT: Here is what the AppVeyor run looks like:
https://ci.appveyor.com/project/billziss-gh/sshfs/build/18

@Nikratio
Copy link
Contributor

Nikratio commented Aug 1, 2018

Thanks! Will this do any good if I just commit it? I'd rather not burden myself with an AppVeyor account. Is there any way you could set things up?

@billziss-gh
Copy link
Collaborator Author

billziss-gh commented Aug 1, 2018

I think the only way would be for me to be a member of the libfuse organization or the sshfs project. Even then I am not really certain that I would have the necessary permissions to set it up. But I am happy to try if you want.

@Nikratio
Copy link
Contributor

Nikratio commented Aug 2, 2018

Just sent you an invite. Please continue to check non-Cygwin-related changes check with me before comitting (i.e, send a regular pull request).

@billziss-gh
Copy link
Collaborator Author

@Nikratio thanks for the invite. I will look whether I can add AppVeyor support as collaborator tomorrow (it is 12:30am here).

And rest assured that I will always submit any future changes as PR’s for you to review and not direct commits.

@billziss-gh
Copy link
Collaborator Author

@Nikratio I have been unable to add libfuse/sshfs as a project in my AppVeyor account. I am working with AppVeyor support to resolve this. For details please see appveyor/ci#2548.

@billziss-gh
Copy link
Collaborator Author

According to the AppVeyor folks I need libfuse access in order to setup CI for sshfs. So we have the following options:

  • Add me as libfuse member. I should then be able to setup CI for sshfs according to AppVeyor support.
  • Set it up yourself. All you would have to do is sign into AppVeyor using your GitHub account. You would not need to change any settings as all necessary configuration is included in the .appveyor.yml file in this PR.
  • Reject this PR. This is perfectly understandable as this may be more of a headache for you that you want. The disadvantage is that the Cygwin port could suffer from further bitrot.

I am happy to proceed as you see fit.

@Nikratio
Copy link
Contributor

Nikratio commented Aug 5, 2018

Given the effort and care that you have invested in this, I'd be very happy to have you on-board :-).

@billziss-gh
Copy link
Collaborator Author

@Nikratio sorry for the late response and thanks for adding me. For some reason I still do not seem to have the right permissions to do this. So I have asked for the necessary privileges via GitHub Settings. You should see messages regarding "AppVeyor" and "AppVeyor CI".

Thanks.

@Nikratio
Copy link
Contributor

Nikratio commented Aug 9, 2018

Just granted them.

@billziss-gh
Copy link
Collaborator Author

@Nikratio thank you.

I have created an AppVeyor project for libfuse/sshfs. It is available here:

https://ci.appveyor.com/project/billziss-gh/sshfs

The first build failed, because the project is not setup to build without this PR. See the image below:

screen shot 2018-08-09 at 1 45 56 pm

I believe if you accept this PR, AppVeyor builds will work normally.

@Nikratio Nikratio merged commit d0c5fa3 into libfuse:master Aug 11, 2018
@billziss-gh
Copy link
Collaborator Author

Thank you for merging it in. AppVeyor builds now work correctly:

screen shot 2018-08-11 at 9 31 01 am

https://ci.appveyor.com/project/billziss-gh/sshfs

@billziss-gh billziss-gh deleted the appveyor branch August 29, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants