Correct workaround condition for not using handle in sshfs_getattr #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you explain why one of the two is the better choice (leaving aside how it was done it the past)? Also, could you include a patch to the documentation? |
|
Also: thanks for tracking this down and reporting it! |
|
It's not simply a matter of defaults, there is no way to get the original workaround functionality with the code as it is without my proposed change. If you have a buggy sftp server that doesn't support fstat, you currently can't force sshfs to always use path-based stat.
|
|
Got it, thanks. Could you please also update ChangeLog.rst though? |
|
No problem 👌
|
|
Hmm, I made a new release commit to the best of my ability. Let me know if I did the correct thing. |
|
Thanks, but there's no need to make a new release. Just add something along the lines of "The fstat workaround is now working correctly again" to the top of the ChangeLog.rst file. No need to bump the version. |
|
Okay I have updated my repo with the corresponding ChangeLog.rst entry. |
In libfuse<3, when `fstat_workaround` was true, that meant to always use the `path` argument to resolve fgetattr instead of the supplied handle. Before this change, the logic was interpreting `fstat_workaround` to not use the `path` argument when it was true. This change reverts to the libfuse<3 behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In libfuse<3, when
fstat_workaroundwas true, that meant to alwaysuse the
pathargument to resolve fgetattr instead of the suppliedhandle. Before this change, the logic was interpreting
fstat_workaroundto not use thepathargument when it wastrue. This change reverts to the libfuse<3 behavior.