Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort on network timeout #77

Open
Nikratio opened this issue Aug 6, 2017 · 10 comments
Open

Abort on network timeout #77

Nikratio opened this issue Aug 6, 2017 · 10 comments
Assignees

Comments

@Nikratio
Copy link
Contributor

Nikratio commented Aug 6, 2017

We should take a look at the following patch, it may be worth merging:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=720455

@Nikratio Nikratio self-assigned this Aug 6, 2017
@Soukyuu
Copy link

Soukyuu commented Aug 6, 2017

That would probably solve issue #3

@alexisfrjp
Copy link

I have the same problem. Was the patch implemented? Is it a closed issue?

@Nikratio
Copy link
Contributor Author

Nikratio commented May 3, 2018

Nope, this is still open. Pull requests welcome :-).

@aerusso
Copy link

aerusso commented Sep 18, 2018

[email protected] did actually return my email (to the fuse mailing list back in 2013)

Thanks for the patch. How about using existing ssh options for this?

-oServerAliveInterval=30

will disconnect after 90sec of network outage. It will also disconnect when
there's no sshfs activity, but together with -oreconnect that should work fine
most of the time.

The problem with setting a default timeout is that there's no one value that's
suitable for all users. And the safest is no timeout, even though it may not be
the most user friendly (ssh also has the timeout disabled by default).

Thanks,
Miklos

I've been using those options since then, and it resolved my issue. IMO -oServerAliveInterval=30 is a better default than no timeout, but it's a little late to change that default now.

@smheidrich
Copy link
Contributor

If that does indeed solve it, it would be nice if it could be explained in the documentation somewhere, perhaps as an extra section on network timeouts.

@Nikratio
Copy link
Contributor Author

@smheidrich Could you give it a shot? Happy to review pull requests :-).

@smheidrich
Copy link
Contributor

@Nikratio Sure, I'll try to write one this weekend :)

smheidrich added a commit to smheidrich/sshfs that referenced this issue Sep 24, 2018
Also rename "SSHFS hangs" section to something more specific to
differentiate it from this new section.

Cf. issues libfuse#77 and libfuse#3.
smheidrich added a commit to smheidrich/sshfs that referenced this issue Sep 24, 2018
Also rename "SSHFS hangs" section to something more specific to
differentiate it from this new section.

Cf. issues libfuse#77 and libfuse#3.
Nikratio pushed a commit that referenced this issue Dec 22, 2018
Also rename "SSHFS hangs" section to something more specific to
differentiate it from this new section.

Cf. issues #77 and #3.
@maccadia
Copy link

I ran into this today. As I understand, the patch (a9a2d75) won't be merged because setting a timeout is not a good choice for everyone. However, it could be useful to have a warning in logs when sshfs is taking a long time.

In my case, it took quite some time to identify that the hanging was caused by sshfs. We use sshfs to mount $HOME ; everything was frozen and no clues in the logs.

@Nikratio
Copy link
Contributor Author

Pull requests are welcome :-).

@maccadia
Copy link

Unfortunately, I'm not a dev. Let's hope someone will have some time for that. It's not critical anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants