Don't contradict referencing sentence in footnote #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The footnote claiming that reading the fd_set takes time proportional to the number of fds is confusing, since both the sentence referencing that footnote and the example right above that sentence are saying that the time is proportional to the largest fd. Of course it's possible to do better by storing the fds separately, but the footnote should not imply that this was done here.
nmathewson
added a commit
that referenced
this pull request
Mar 31, 2014
Don't contradict referencing sentence in footnote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The footnote claiming that reading the fd_set takes time proportional to
the number of fds is confusing, since both the sentence referencing that
footnote and the example right above that sentence are saying that the
time is proportional to the largest fd.
Of course it's possible to do better by storing the fds separately, but
the footnote should not imply that this was done here.