erfadatextra.h #ifndef
#87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enables source_flattener.py to scrape until #endif
|
@RocketRoss - that looks good and makes sense - we really should have had that (just goes to show how poor my C is...) Will just check that the tests pass - but I don't see how they could not! |
|
Just the smallest oversight, happy to help patch. Only came up because of the flatten_sources.py if erfa_fetch. Thanks! |
|
@RocketRoss - just noticed something silly, but might as well fix it - there is a missing new-line at the end of the file. Could you fix that? (Happy to do it myself if that's easier) |
|
Sorted 👍 |
|
@mhvk I think that you need to approve the test execution in order to run tests |
|
@RocketRoss - thanks! Will merge once tests have run again. |
|
@mhvk Success :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables source_flattener.py to scrape until #endif and succeed.