Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note that the erfaversion.c needs updating #65

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

eteq
Copy link
Member

@eteq eteq commented Jan 16, 2020

This PR addresses the underlying problem that led to #62 : that I followed the instructions for updating which were never updated to mention erfaversion.c - now it says clearly to check that in addition to the readme and AC_INIT .

@eteq eteq requested review from sergiopasra and mhvk January 16, 2020 05:32
@mhvk
Copy link
Contributor

mhvk commented Jan 16, 2020

Probably, we should ensure more gets autogenerated from one source, but in the meantime, let's get this in.

@mhvk mhvk merged commit 7ed1d4d into liberfa:master Jan 16, 2020
@mhvk
Copy link
Contributor

mhvk commented Sep 17, 2020

Hmm, despite this change, I still got caught out! See #73 for another attempt to avoid this... Would be good to try to auto-generate...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants