Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback from curl_multi_poll to curl_multi_wait before curl 7.66 #1055

Merged
merged 1 commit into from
May 30, 2024
Merged

fix: fallback from curl_multi_poll to curl_multi_wait before curl 7.66 #1055

merged 1 commit into from
May 30, 2024

Conversation

TontonJambon
Copy link

According to this article, curl_multi_poll is a "drop-in function replacement" to curl_multi_wait that "waits more", and was introduced in 7.66.

Replace call to curl_multi_poll by curl_multi_wait when curl version is less that 7.66.

Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@COM8
Copy link
Member

COM8 commented May 28, 2024

You are missing a #include <curl/curlver.h> include.

@COM8 COM8 merged commit bf4bb36 into libcpr:master May 30, 2024
49 of 53 checks passed
@TontonJambon TontonJambon deleted the fix/curl_multi_poll_undefined branch May 30, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants