Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

补全幻系列武将;素材补充;武将bugfix;部分武将分包移动和描述勘误 #1484

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

xizifu
Copy link
Contributor

@xizifu xizifu commented Jun 16, 2024

PR受影响的平台

全部平台

诱因和背景

PR描述

1.海外幻系列武将诸葛亮、姜维;
2.朱佩兰语音台词素材补充;
3.阳球、谋公孙瓒、幻魏延、幻赵云、OL谋袁绍bugfix;标程普添加ai;
4.李婉分包移动;OL谋袁绍描述更正

PR测试

已进行新武将测试,未有明显bug

扩展适配

检查清单

  • 我已经进行了充足的测试,且现有的测试都已通过
  • 如果此次PR中添加了新的武将/新的语音文件,则我已在character/rank.js中添加对应的武将强度评级/在lib.translate中加入语音文件的文字台词
  • 如果此次PR涉及到新功能的添加,我已在PR描述中写入详细文档
  • 如果此次PR需要扩展跟进,我已在扩展适配中写入详细文档
  • 如果这个PR解决了一个issue,我在诱因和背景中明确链接到该issue
  • 我保证该PR中没有随意修改换行符等内容,没有制造出大量的Diff
  • 我保证该PR遵循项目中.editorconfigeslint.config.mjsprettier.config.mjs所规定的代码样式,并且已经通过prettier格式化过代码

@Spmario233 Spmario233 merged commit 5718cc4 into libccy:PR-Branch Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants