Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible items on item rows #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahukkanen
Copy link

When there are invisible items on some rows, the top positions are sometimes calculated incorrectly.

This happens in specific cases where we want to show specific items on desktop, specific items on tablet and specific items on mobile.

For example, the structure can be as follows:

Desktop
[ item 1 ] [ item 2 ] [ item 3 ]

Tablet
[ item 1 ] [ item 2 ]
[ item 4 ] [ item 5 ]

Mobile
[ item 1 ]
[ item 2 ]
[ item 3 ]
[ item 4 ]
[ item 5 ]

As shown, in this case the following applies:

  • On desktop, items 4 and 5 are hidden
  • On tablet, item 3 is hidden (which is in the middle of items 2 and 4)

This causes the second row to be calculated incorrectly in specific situations on table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant