bind/unbind deprecated in jQuery 3

[mariusconjeaud]

As of jQuery3, bind() and unbind() methods are deprecated. Replaced by on() and off() methods as required.

[liabru]

The reason for using bind was for back compatibility. Maybe there's a way to detect?

[priley86]

+1, would like to see this fix so our patternfly project can support jQuery v3.

[andresgalante]

👍

[priley86]

Hi @liabru, please consider that on() and off() are supported in jquery 1.7+

This should give your library adequate support for each major version of jquery currently in use (jquery 1, 2, 3). jquery 1.7 should still provide adqeuate support of IE 6,7, and 8.
See https://api.jquery.com/category/version/1.7/

Please re-consider merging this PR 😄

[liabru]

Might it be possible to do something like:

var on = $.fn.on ? 'on' : 'bind';

$(window)[on](function() {
  // ...
});

To maintain backwards compatibility, as this plugin has widespread usage on many older codebases. I'd rather not drop support for them if I can easily keep it, if that makes sense?
I'll try this out when I can.

[rylan]

If the project is using semantic versioning, another approach to supporting backwards compatibility is to bump the version into the 1.0.0 (meaning major change) and those needing backward compatibility for jquery versions older then 1.7 lock into the 0.7.X version.

[Preen]

yes?