Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch E486 to prevent error after removing silent navigation #34

Merged
merged 2 commits into from
May 12, 2018

Conversation

myii
Copy link
Contributor

@myii myii commented May 11, 2018

This follows-on from issue #33, which resulted in commit b425bb4.

Unfortunately, one side-effect of removing silent! is that E486: Pattern not found: <pattern> is now seen as an error in WordNavigation. Also requires the extra key press to get rid of the error.

Credit for this resolution is:

Finally, this isn't perfect, in that the E486 message is no longer displayed after hitting n or N -- instead, it shows search hit BOTTOM, continuing at TOP (or vice versa). But the meaning is still correct and this avoids the ugly error.

@myii
Copy link
Contributor Author

myii commented May 11, 2018

Just added another commit, which simulates the E486 as a warning instead. In a general sense, that brings the functionality in line with standard Vim.

@lfv89 lfv89 merged commit 7e3ec6a into lfv89:master May 12, 2018
@lfv89
Copy link
Owner

lfv89 commented May 12, 2018

I was going to work on this today! 😄

Thanks again @myii

@myii myii deleted the myii-patch-1 branch May 12, 2018 17:14
@myii
Copy link
Contributor Author

myii commented May 12, 2018

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants