added feature to ignore checks fixed #38 #80
Conversation
omkarkhatavkar
force-pushed
the
fix_38
branch
4 times, most recently
from
4f91e85
to
df56dec
Compare
|
@matiasalbarello can chance to review this and getting merged ? |
ssaunier
force-pushed
the
master
branch
3 times, most recently
from
7421a35
to
60446b9
Compare
omkarkhatavkar
force-pushed
the
fix_38
branch
from
3792837
to
09e595c
Compare
|
@matiasalbarello do you feel that this is useful and working okay? |
| @@ -47,6 +48,8 @@ def log_checks(checks, msg) | |||
|
|
|||
| def apply_filters(checks) | |||
| checks.reject! { |check| check.name == workflow_name } | |||
| checks.reject! { |check| ignore_checks.include?(check.name) } | |||
There was a problem hiding this comment.
In order to avoid iterating the array twice (by calling reject), I'd suggest joining both of them:
checks.reject! { |check| [ignore_checks, workflow_name].flatten.include?(check.name) }
There was a problem hiding this comment.
Thanks Done !
|
thanks for the PR! I think that overall it looks ok. I left a few comments :) |
|
@omkarkhatavkar, it seems that a test got broken. Could you fix it? |
omkarkhatavkar
force-pushed
the
fix_38
branch
from
371d6d9
to
0f57c52
Compare
@matiasalbarello it's hard for me to debug the ruby code, not know much about the stuff, I do fix the issue can you please cross-check? |
This PR will add the feature requested for #38