Adopt zlint for CRL linting #6934
Assignees
Milestone
Comments
|
Currently, zlint has only one CRL lint: lint_crl_has_next_update. Three more are in progress. |
This was referenced Jul 1, 2023
aarongable
added a commit
that referenced
this issue
Jul 5, 2023
The upstream zlint lints are organized not by what kind of certificate they apply to, but what source they are from. This change rearranges (and slightly renames) our custom lints to match the same structure. This will make it easier for us to temporarily add lints (e.g. for our CRLs) which we intend to upstream to zlint later. Part of #6934
Merged
pgporada
pushed a commit
that referenced
this issue
Jul 6, 2023
This brings in infrastructure to support linting CRLs. Release notes: https://github.com/zmap/zlint/releases/tag/v3.5.0 Changelog: zmap/zlint@v3.4.0...v3.5.0 Part of #6934
aarongable
added a commit
that referenced
this issue
Jul 11, 2023
Update zlint to v3.5.0, which introduces scaffolding for running lints over CRLs. Convert all of our existing CRL checks to structs which match the zlint interface, and add them to the registry. Then change our linter's CheckCRL function, and crl-checker's Validate function, to run all lints in the zlint registry. Finally, update the ceremony tool to run these lints as well. This change touches a lot of files, but involves almost no logic changes. It's all just infrastructure, changing the way our lints and their tests are shaped, and moving test files into new homes. Fixes #6934 Fixes #6979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zlint 3.5.0 now has support for linting CRLs! We should adopt this and use it to replace our existing crl lints, and contribute our checks upstream if any of them are missing.
The text was updated successfully, but these errors were encountered: