Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in import subpath module #4236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HridoyHazard
Copy link

@HridoyHazard HridoyHazard commented Oct 3, 2023

What: i fixed this issue : #3715

Why: with this changes the issue get fixed.

Checklist:

  • Documentation
  • Added/updated unit tests
  • Code complete

@HridoyHazard
Copy link
Author

hi @iChenLei can you plz check this pr ? and merge it under hacktoberfest

@HridoyHazard
Copy link
Author

@matthew-dean hi is everything ok this this pr ? if no plz tell me what's wrong and how to fix it

@matthew-dean
Copy link
Member

Without any tests added to this PR, proving the issue and proving that this fix fixes it, I don't see how this can be merged.

@HridoyHazard
Copy link
Author

Without any tests added to this PR, proving the issue and proving that this fix fixes it, I don't see how this can be merged.

can you put it in test? i don't know how to test it. but seems it fixed the issue

@HridoyHazard
Copy link
Author

@matthew-dean hi can you plz provide any feedback ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants