MenuItem header is visually inconstant when using _ to indicate shortcut keys

[TheJoeFin]

Describe the bug

Within MenuItems you can add an underscore before the letter you want to use as the shortcut key. When using WPF UI adding underscores to the MenuItem makes the text a different style than menu items without an underscore.

To Reproduce

Add underscores to the header item in the MenuItem Header

Expected behavior

Consistent look across all MenuItems

Screenshots

    <ContextMenu x:Key="ContextMenuResource">
        <MenuItem Command="ApplicationCommands.Undo" />
        <MenuItem Command="ApplicationCommands.Redo" />
        <Separator />
        <MenuItem Command="ApplicationCommands.Cut" />
        <MenuItem Command="ApplicationCommands.Copy" />
        <MenuItem Command="ApplicationCommands.Paste" />
        <MenuItem
            Command="{x:Static local:EditTextWindow.OcrPasteCommand}"
            Header="OCR Paste"
            InputGestureText="Ctrl + Shift + V" />
        <Separator />
        <MenuItem
            Command="{x:Static local:EditTextWindow.IsolateSelectionCmd}"
            Header="Isolate Selected Text"
            InputGestureText="Ctrl + I" />
        <MenuItem
           Click="SelectLineMenuItem_Click"
           Header="Select Line"
            InputGestureText="Ctrl + L" />
        <MenuItem
           Command="{x:Static local:EditTextWindow.ToggleCaseCmd}"
           Header="Toggle Case"
           InputGestureText="Shift + F3" />
        <Separator />
        <MenuItem
            Click="MoveLineUpMenuItem_Click"
            Header="Move Selection _Up"
            InputGestureText="Alt + Up" />
        <MenuItem
            Click="MoveLineDownMenuItem_Click"
            Header="Move Selection _Down"
            InputGestureText="Alt + Down" />
    </ContextMenu>

OS version

Windows 11
Version 22H2 (OS Build 22621.1413)

.NET version

.NET 6

WPF-UI NuGet version

3.0.0.preview.1

Additional context

No response

[Chri-s]

I have the same problem, it seems that the header with an underscore is displayed in AccessText instead of TextBlock.

I fixed this in my project by copying the style from the TextBlock (

wpfui/src/Wpf.Ui/Controls/TextBlock/TextBlock.xaml

Line 10 in f59daa0

<Style TargetType="{x:Type TextBlock}">

) and assigning it to AccessText in my project styles:

<!--  This is copied from the Wpf.UI TextBlock style.
        If a text contains an underscore ("_"), the TextBlock is replaced with AccessText.
        Wpf.Ui doesn't style the AccessText so has another look than text without underscore.
        This gives AccessText the same look as TextBlock. -->
<Style TargetType="{x:Type AccessText}">

    <!--<Setter Property="Foreground" Value="{DynamicResource TextFillColorPrimaryBrush}"/>-->

    <!--  The Display option causes a large aliasing effect  -->
    <!--<Setter Property="TextOptions.TextFormattingMode" Value="Ideal" />-->
    <Setter Property="Background" Value="Transparent" />
    <Setter Property="FontSize" Value="14" />
    <Setter Property="Margin" Value="0" />
    <Setter Property="Focusable" Value="False" />
    <Setter Property="SnapsToDevicePixels" Value="True" />
    <Setter Property="OverridesDefaultStyle" Value="True" />
</Style>```

[Chri-s]

Wow, thanks for the fast fix!👍