Add Synchronic SAM-SE Key Store #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxhy
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Ideally the Click events are avoided and binding is directly done to the ViewModel on Button command. But this guideline is not always followed even on current plugins. This is more a goal to reach atm.
| IsExpanded="{Binding LockedLevelExpanded}" | ||
| Header="{x:Static properties:Resources.ToolsLockUnlock}"> | ||
| <WrapPanel Orientation="Vertical" TextBlock.Foreground="{DynamicResource MaterialDesignBody}" Margin="24,8,24,16"> | ||
| <Grid Margin="-120,0,-120,10"> |
| PreviewTextInput="NumberValidationTextBox" | ||
| Text="{Binding SAM_SEProperties.DESFire.AidString, Mode=TwoWay}" | ||
| materialDesign:HintAssist.Hint="{x:Static properties:Resources.DESFireAid}" | ||
| ContextMenu="{x:Null}"/> |
There was a problem hiding this comment.
ContextMenu set to null is required?
| </Grid.ColumnDefinitions> | ||
| <TextBlock Grid.Row="0" Grid.Column="0" Margin="0,0,0,0" | ||
| Text="{x:Static properties:Resources.KeyEntryDESFireEncryption}" | ||
| FontSize="9" Foreground="DarkGray"/> |
There was a problem hiding this comment.
Hardcoded colors should be avoided to be sure it works with Light/Dark themes. It would be better to reference MaterialDesign theme colors. This comment is for all hardcoded colors on this file.
|
|
||
| //All the mechanic of Update is based on this list | ||
| //If it's empty, we must populate it with a GetAll | ||
| if (_keyEntries.Count == 0) |
There was a problem hiding this comment.
Is it really required here or on Store method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Synchronic SAM-SE Key Store :