Expression simplifier #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
simplifier
branch
2 times, most recently
from
e26f484
to
5b45928
Compare
leonardoalt
reviewed
Jan 2, 2023
src/evaluator/simplifier.rs
Outdated
| if let Value::Op(opcode, mut args) = input { | ||
| let mask = (BigUint::from(1u64) << 256) - BigUint::from(1u64); | ||
| let two256 = BigUint::from(1u64) << 256; | ||
| let two255: BigUint = BigUint::from(1u64) << 255; |
There was a problem hiding this comment.
why is the type annotation needed here?
There was a problem hiding this comment.
Not sure, but it is.
leonardoalt
reviewed
Jan 2, 2023
src/evaluator/simplifier.rs
Outdated
|
|
||
| pub fn simplify(input: Value) -> Value { | ||
| if let Value::Op(opcode, mut args) = input { | ||
| let mask = (BigUint::from(1u64) << 256) - BigUint::from(1u64); |
leonardoalt
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.