Extract variable handling. #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
commented
Oct 10, 2022
| pub identifier: Identifier, | ||
| pub domain: Vec<SMTSort>, | ||
| pub codomain: SMTSort, | ||
| pub default_value: Option<SMTExpr>, |
There was a problem hiding this comment.
This could be a bit of a hindrance later, but I would say let's keep it for now, we can always refactor further.
There was a problem hiding this comment.
what exactly do you mean? The default value or the whole thing?
chriseth
commented
Oct 10, 2022
src/variables.rs
Outdated
| /// Declares a new SSA index for the given variable and sets it to | ||
| /// "unknown" if the condition is false and to the old value if it is true. | ||
| #[must_use] | ||
| pub fn havoc_unless( |
There was a problem hiding this comment.
Do you think these should better be member functions?
There was a problem hiding this comment.
Might be cleaner when reading yea
chriseth
commented
Oct 10, 2022
src/variables.rs
Outdated
| use crate::smt::{self, SMTExpr, SMTSort, SMTStatement, SMTVariable}; | ||
| use crate::ssa_tracker::SSATracker; | ||
|
|
||
| pub struct Variable { |
There was a problem hiding this comment.
Do you have an idea for a better name?
There was a problem hiding this comment.
yea, or EnvVariable? ContextVariable?
leonardoalt
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.