-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relevant line calculation difference between python versions, related to -0.0% change? #1608
Comments
Hi @jtroussard.
On the Coveralls side of things it's hard to account for differences between any two coverage reports received by the API. Our calculations are based on the data in each report, which is to say, we simply accept what the reports tell us and can't account for things like why the same coverage library determines one line to be relevant on one OS version and not relevant on the other. The best you can do to ensure some reasonably expected uniformity in your original coverage reports is to use the same versions of your coverage libraries and generators across all jobs in a build (if possible). If you want to share the Coveralls URL for your repo, and for any build(s) that appear to be affected, we're happy to look more deeply into the specific case. If your project is private, or sensitive, you can email us at [email protected] and refer to this issue.
There is a known issue affecting some projects whereby calculations that should result in a status of "no change" are being returned as decreases (of -0.0%). I suspect you are affected and, if so, then it's not that you're misdiagnosing your coverage changes / failures, it's just that a particular difference between two parallel jobs in your build may or may not be relevant. It is possible that two builds could be one line number off, but that would typically result in a decrease that's more statistically significant than 0.0%.
I'm afraid not at this moment. If you're being affected by the known bug, then to avoid it you'll want to set a value larger than 0.0% for the setting: You'll find that in your repo's settings page on coveralls, which is at:
I have +1'd you on our internal card for the known issue. I'll post any updates here when we get them there. |
Description
Our pipeline runs coverallsapp action in parallel with several different versions of python. Noticed that after making a non-functional change to a file, (removed comment) our coveralls check was failing the build for a -0.0% decrease.
Difference Between Versions
Search results in a small difference the relevant lines are calculated between python versions:
3.7![37](https://user-images.githubusercontent.com/17488893/147888827-fc58b89f-6fb1-4675-8233-e4a686394637.PNG)
3.8![38](https://user-images.githubusercontent.com/17488893/147888832-a10065ad-b744-41eb-8df4-d13001f79bbd.PNG)
The difference between the 2 are the method declaration lines. 3.6 and 3.7 seem to leave it out, while 3.8 and beyond include the line as "relevant". This is the only significant difference I can find between the passing coveralls checks (3.6, 3.7) and the failing checks, (3.8, 3.9)
coveralls github action results
![Screen Shot 2022-01-04 at 2 49 37 PM](https://user-images.githubusercontent.com/17488893/148115582-a16f0faf-ad77-4537-978a-b8b0ff266240.png)
Questions
The text was updated successfully, but these errors were encountered: